[libebml] add - files attached needs review

[michaelvoliveira]

Please review

[scottmc]

For your patch, try copying the BeOS check case statement and pasting it below, now change that new case to be Haiku instead of BeOS.

13 # BeOS wants the libs and headers in /boot/home/config 
14 ifeq (BeOS,$(shell uname -s)) 
15 prefix=/boot/home/config 
16 else 
17 prefix=/usr/local 
18 endif 

{{{
13 # BeOS wants the libs and headers in /boot/home/config 
14 ifeq (BeOS,$(shell uname -s)) 
15 prefix=/boot/home/config 
16 else 
17 prefix=/usr/local 
18 endif 
19
20 # Haiku wants the libs and headers in /boot/common 
21 ifeq (Haiku,$(shell uname -s)) 
22 prefix=/boot/common 
23 else 
24 prefix=/usr/local 
25 endif 
}}}

This then allows it to still work for BeOS, and Linux and Haiku, and would then increase the chances of being accepted upstream one day.
Let's see and updated patch.

Also the .bep file, I doubt that it works as the haikuporter tools seems to have issues extracting from .bz2 archives last I knew.  Are you checking your .bep files with haikuporter yet?

[michaelvoliveira]

Optional Package Description file. now this ticket is complete and ready to be closed

[scottmc]

Please see my comment above, change your patch to add a Haiku section to the Makefile, rather than modifying the BeOS one. This will make for a cleaner patch that can be upstreamed. Also update the .bep file with the LICENSE and COPYRIGHT lines which now make the .OptionalPackageDescription file on the fly. Be sure to update your haikuporter to the latest version and then test to make sure -d and -i options both work without WARNINGS.

[disreali]

Attaching a new .bep for libebml-1.0.0 release. Patch to follow. libebml src is only released as a tar.bz2.

[disreali]

bep now includes md5sum

[disreali]

Updated patchfile

[disreali]

Please review patch and .bep for libebml-1.0.0 and give feedback if changes are needs. If no changes are needed, please commit.

[disreali]

fixes extra else error

[disreali]

Attached modified patch that fixes an extra 'else' error.

Scott pointed out that a DESTDIR hack may needed to be added in order for proper building of bep. Will attempt soon.

[scottmc]

Updated patch in r1045.