add ilmbase - fails to build with gcc2

[michaelvoliveira]

IlmImf?, a library that reads and writes OpenEXR images.

[michaelvoliveira]

this lib is required in order to build openexr

[michaelvoliveira]

Optional Package Description file. So, this ticket is complete to review ;)

[scottmc]

added in r646, please check on both gcc2 and gcc4 builds and see if either or both of them work. Here I'm getting an error during make (with a gcc2 only haiku):

config.status: creating config/IlmBaseConfig.h
config.status: executing depfiles commands
config.status: executing libtool commands

---------------------------------------------
Summary for IlmBase features:

No variable options in this package.  Configure completed successfully.
---------------------------------------------
  
Making all in Half
make[1]: Entering directory `/boot/develop/haikuports/media-libs/ilmbase/work/ilmbase-1.0.1/Half'
source='eLut.cpp' object='eLut.o' libtool=no \
        DEPDIR=.deps depmode=gcc /bin/sh ../depcomp \
        g++ -DHAVE_CONFIG_H -I. -I../config -I../config   -pipe -g -O2  -c -o eLut.o eLut.cpp
/bin/sh ../libtool --tag=CXX   --mode=link g++ -pipe -g -O2    -o eLut eLut.o  
libtool: link: g++ -pipe -g -O2 -o eLut eLut.o 
./eLut > eLut.h
source='toFloat.cpp' object='toFloat.o' libtool=no \
        DEPDIR=.deps depmode=gcc /bin/sh ../depcomp \
        g++ -DHAVE_CONFIG_H -I. -I../config -I../config   -pipe -g -O2  -c -o toFloat.o toFloat.cpp
/boot/develop/haikuports/media-libs/ilmbase/work/ilmbase-1.0.1/Half/toFloat.cpp: In function `int main()':
/boot/develop/haikuports/media-libs/ilmbase/work/ilmbase-1.0.1/Half/toFloat.cpp:138: `ios_base' undeclared (first use this function)
/boot/develop/haikuports/media-libs/ilmbase/work/ilmbase-1.0.1/Half/toFloat.cpp:138: (Each undeclared identifier is reported only once
/boot/develop/haikuports/media-libs/ilmbase/work/ilmbase-1.0.1/Half/toFloat.cpp:138: for each function it appears in.)
/boot/develop/haikuports/media-libs/ilmbase/work/ilmbase-1.0.1/Half/toFloat.cpp:138: parse error before `::'
make[1]: *** [toFloat.o] Error 1
make[1]: Leaving directory `/boot/develop/haikuports/media-libs/ilmbase/work/ilmbase-1.0.1/Half'
make: *** [all-recursive] Error 1
Traceback (most recent call last):
  File "/boot/common/bin/haikuporter", line 956, in <module>
    haikuporter = HaikuPorter(options, args)
  File "/boot/common/bin/haikuporter", line 240, in __init__
    self.buildPort()    # build
  File "/boot/common/bin/haikuporter", line 641, in buildPort
    self.runCommandSequence(self.bepKeys['BUILD'], self.workDir)
  File "/boot/common/bin/haikuporter", line 765, in runCommandSequence
    check_call(commandString, shell=True, cwd=dir, env=shellEnv)
  File "/boot/common/lib/python2.6/subprocess.py", line 488, in check_call
    raise CalledProcessError(retcode, cmd)
subprocess.CalledProcessError: Command 'cd ilmbase-1.0.1 && libtoolize --copy --force --install && ./bootstrap && ./configure --prefix=/boot/common && make' returned non-zero exit status 2
/boot/develop/haikuports/media-libs> 

[augiedoggie]

If you need to, you can probably just diff the files against the Haiku versions. All of the ilm/exr stuff is in the repository for the openexr translator add-on.

They are spread out in:
src/add-ons/translators/exr/openexr

[michaelvoliveira]

updated download location

[michaelvoliveira]

Done in r1071

GCC4 builds fine

Thanks!

[scottmc]

This still fails to build with gcc2. It'll probably need to be patched. Diff it against the fails in the haiku repo as augiedoggie suggested above. This holds up openexr, which then holds up devil and perhaps others.

[michaelvoliveira]

I can use '#if GNUC > 2' in the code???

for example 'ios_base::hex' for gcc2 is 'ios:hex'

[scottmc]

compare vs. the code in  http://dev.haiku-os.org/browser/haiku/trunk/src/add-ons/translators/exr/openexr?order=name

[bonefish]

Replying to michaelvoliveira:

I can use '#if GNUC > 2' in the code???

for example 'ios_base::hex' for gcc2 is 'ios:hex'

Just use ios::hex. Since ios is derived from ios_base, this also works when hex is correctly defined in ios_base (and is less to write :-)).

[pulkomandy]

I tried to fix the ios issue, but then I see that toFloat.h is not generated properly (file is truncated). Any idea why ?

[scottmc]

no need to get this building on gcc2 as long as it works on hybrid? closing as won't fix.