[allegro] building problems with gcc4

[michaelvoliveira]

while I trying to build allegro with gcc4 I face this error:

gcc -DALLEGRO_SRC -DALLEGRO_LIB_BUILD -Wall -Wno-unused -Wno-multichar -Wno-ctor-dtor-privacy -mtune=i586 -O6 -funroll-loops -ffast-math -fomit-frame-pointer -DALLEGRO_NO_ASM -I. -I./include -o obj/beos/alleg/bdwindow.o -c src/beos/bdwindow.cpp
src/beos/bdwindow.cpp: In function 'BITMAP* _be_gfx_bdirectwindow_init(GFX_DRIVER*, int, int, int, int, int)':
src/beos/bdwindow.cpp:416: error: invalid conversion from 'uintptr_t (*)(BITMAP*, int)' to 'void*'
src/beos/bdwindow.cpp:417: error: invalid conversion from 'uintptr_t (*)(BITMAP*, int)' to 'void*'
src/beos/bdwindow.cpp:418: error: invalid conversion from 'void (*)(BITMAP*)' to 'void*'
make: *** [obj/beos/alleg/bdwindow.o] Error 1

Seems that a problem with compiling without asm enabled

bdwindow.cpp

415 #ifdef ALLEGRO_NO_ASM
416    bmp->read_bank = _be_gfx_bwindow_read_write_bank;
417    bmp->write_bank = _be_gfx_bwindow_read_write_bank;
418    _screen_vtable.unwrite_bank = _be_gfx_bwindow_unwrite_bank;
419 #else

[drcouzelis]

These patches will allow allegro-4.4.1.1 to compile in Haiku gcc4-hybrid.

By the way, I'm new to submitting patches, new to Haiku, and even more new to Haiku Ports.

[drcouzelis]

I'm sorry, I forgot to mention: These patches allow Allegro to compile, BUT I have not tested it.

[michaelvoliveira]

Created a better patch based on drcouzelis patches

[scottmc]

applied in r1025, thanks.

[michaelvoliveira]

still have problems with gcc4:

launch any app by double clicking is getting the following output

[tcsetpgrp failed in terminal_inferior: Invalid Argument]
[Switching to team /boot/apps/opensnc/opensurge (294) thread system driver (295)]
system_thread (data=0x0)
    at /boot/develop/haikuports/media-libs/allegro/work/allegro-4.4.1.1/src/beos/bsysapi.cpp:131
131           if (!strcmp(term, "dumb")) {
(gdb) bt
#0  system_thread (data=0x0)
    at /boot/develop/haikuports/media-libs/allegro/work/allegro-4.4.1.1/src/beos/bsysapi.cpp:131
#1  0x0049fbc4 in thread_entry () from /boot/system/lib/libroot.so
#2  0x7003ffec in ?? ()
Current language:  auto; currently c++
(gdb)

and play from terminal, the app launch, but the window image is not "updated" (needs to be moving around with mousedown), and is NOT PLAYING any sound as you see below:

[diver]

Fixed in  https://bitbucket.org/haikuports/haikuports/commits/d289d81e5a589c69b07159d8f4f5968ea3acbf8a