[libsndfile] add - files attached needs review

[michaelvoliveira]

A C library for reading and writing files containing sampled sound

[michaelvoliveira]

Optional Package Description file. So, this ticket is complete to review ;)

[augiedoggie]

The OPD file contains some invalid data but it needs to be merged into the bep file anyhow. The license names must be exactly the same as the ones in /boot/system/data/licenses. For example 'GNU LGPLv.2.1' should be 'GNU LGPL v2.1' and 'GNU LGPLv.3' should be 'GNU LGPL v3'

[scottmc]

using the last .bep file you posted it's failing to build for me with this error:

In file included from /boot/develop/haikuports/media-libs/libsndfile/work/libsndfile-1.0.21/src/sds.c:26:
/boot/develop/headers/posix/math.h:184: warning: declaration of `exp' shadows global declaration
  CC    svx.o
  CC    txw.o
  CC    voc.o
  CC    wve.o
  CC    w64.o
  CC    wav_w64.o
  CC    wav.o
/boot/develop/haikuports/media-libs/libsndfile/work/libsndfile-1.0.21/src/wav.c: In function `wav_write_header':
/boot/develop/haikuports/media-libs/libsndfile/work/libsndfile-1.0.21/src/wav.c:1131: Internal compiler error, output_operand_lossage `invalid expression as operand'
make[3]: *** [wav.lo] Error 1
make[2]: *** [all-recursive] Error 1
make[1]: *** [all] Error 2
make: *** [all-recursive] Error 1

Did you patch it and forget to include it? Or were you using gcc4 instead of gcc2?

[michaelvoliveira]

corrected license entry

[michaelvoliveira]

humm... seems that this one only builds with GCC4.. because when I set gcc2, configure command return the following warning

configure: WARNING: *** This compiler does not support the 1999 ISO C Standard ***
configure: WARNING: *** feature known as the flexible array struct member.     ***

Will be necessary create a patch to handle it, but I don't know how

[michaelvoliveira]

Beyond that, sndfile-play-beos.cpp has to be updated to play sound files in Haiku

[michaelvoliveira]

Patch to update sndfile-play-beos functions! it play sounds now!! \o/ and Replace orginal sndfile-play

[michaelvoliveira]

fixed: Done in r1087. Thanks!

[michaelvoliveira]

This lib will never build to GCC2.

There's a compiler bug, fixed in > 4.2 versions

 http://gcc.gnu.org/bugzilla/show_bug.cgi?id=34688