Ticket #293 (closed defect: fixed)
Opened 5 years ago
Last modified 5 years ago
[vim] gui_mch_get_winpos() always returns (0,0)
| Reported by: | stimut | Owned by: | siarzhuk |
|---|---|---|---|
| Priority: | normal | Milestone: | |
| Component: | app-editors/vim | Version: | |
| Severity: | normal | Keywords: | |
| Cc: |
Description
In gui_mch_get_winpos() (in src/gui_beos.cc) the code uses Bounds() instead of Frame(). Since Bounds() returns values relative to the coordinate system of the window, left and top will always be 0 and 0. This means getwinposx() and getwinposy() from within vim always returns 0, which (apart from anything else) in turn means the taglist plugin moves the gvim window to 0,0 when the taglist window is closed.
The fix: change line 2646 (r317) of src/gui_beos.cc to:
r = gui.vimWindow->Frame();
Attachments
Change History
comment:1 Changed 5 years ago by siarzhuk
- Owner changed from scottmc to siarzhuk
comment:2 in reply to: ↑ description ; follow-up: ↓ 3 Changed 5 years ago by siarzhuk
comment:3 in reply to: ↑ 2 Changed 5 years ago by scottmc
2 scottmc: Could you, please, assign me as default owner of app-editors/vim Trac component? Thank you!
you got it, if there's any others just let me know...
comment:4 follow-up: ↓ 5 Changed 5 years ago by stimut
I've even created a patch with the fix, and tested in on my computer, to increase the likelihood of it being committed.
I'm assuming I don't get commit access with this account :).
Changed 5 years ago by stimut
- attachment vim-7.2.patch.diff added
comment:5 in reply to: ↑ 4 Changed 5 years ago by siarzhuk
Replying to stimut:
I've even created a patch with the fix, and tested in on my computer, to increase the likelihood of it being committed.
I'm assuming I don't get commit access with this account :).
Thank you. :-) I'll commit this today evening.
comment:6 Changed 5 years ago by siarzhuk
- Resolution set to fixed
- Status changed from new to closed
Patch applied in r595. Thank you and sorry for delay.
Thanks!