Ticket #331 (closed enhancement: fixed)
Opened 5 years ago
Last modified 5 years ago
add dev-util/quilt
| Reported by: | mjw | Owned by: | mjw |
|---|---|---|---|
| Priority: | normal | Milestone: | |
| Component: | dev-util/quilt | Version: | |
| Severity: | normal | Keywords: | |
| Cc: |
Description
I have ported dev-util/quilt to Haiku. Various files are attached to this ticket.
Attachments
Change History
comment:1 Changed 5 years ago by augiedoggie
comment:2 Changed 5 years ago by augiedoggie
I see that the hardlink check was removed in the git version. If you fix the OPD file and test the new install command then it should be ok.
comment:3 Changed 5 years ago by scottmc
- Summary changed from Please add dev-util/quilt to add dev-util/quilt
comment:4 Changed 5 years ago by scottmc
- Component changed from default to dev-util/quilt
- Owner set to mjw
comment:5 Changed 5 years ago by mjw
The only reference to the hardlink "cp" command was in the release notes - and that reference was saying that it was no longer used, so I assumed it was fairly safe to remove the check. I could not find a reference to it in the code.
haikuporter -i and haikuporter -d work with my current .bep, but I'll change the .bep as you suggest.
I will look at the other changes.
Changed 5 years ago by mjw
- attachment quilt.OptionalPackageDescription added
Changed 5 years ago by mjw
- attachment quilt-0.48.2.bep added
Changed 5 years ago by mjw
- attachment quilt-0.48.bep added
Changed 5 years ago by mjw
- attachment quilt-0.48.patch added
comment:6 Changed 5 years ago by mjw
All attachments are updated.
comment:7 Changed 5 years ago by augiedoggie
- Resolution set to fixed
- Status changed from new to closed
Added in r752
I'm sure the other install command would probably have worked. I was just nit picking.

It appears as though the OptionalPackageDescription has incomplete copyright information. In addition the license name must match one in /boot/system/data/licenses. In this case it appears the license name should be 'GNU GPL v2'
It's generally not a good idea to remove checks from a configure.ac file. Is there a way to disable this check on Haiku? Does the test suite run without hard link capability?
The install section of bep files can be tricky when it doesn't properly support DESTDIR. In this case though it looks as though you should do something like:
make install BUILD_ROOT="${DESTDIR}"Perhaps you can test this with 'haikuporter -d' and verify that the package is built properly.