[gloox] add -needs work (corrected)

[michaelvoliveira]

gloox is a rock-solid, full-featured Jabber/XMPP client library, written in clean ANSI C++. It makes writing spec-compliant clients easy and allows for hassle-free integration of Jabber/XMPP functionality into existing applications.

 http://camaya.net/gloox/

[augiedoggie]

This one looks pretty good. It is checking for the extra headers in the configure script but maybe you should add a guard when using them in the source files. The string.h header should be common on most operating systems but some probably won't have wchar.h.

#if HAVE_STRING_H
#include <string.h>
#endif

#if HAVE_WCHAR_H
#include <wchar.h>
#endif

These variables are automatically defined by the configure process and stored in the config.h.unix header file. This will make sure that it doesn't break on other operating systems if we submit the patch upstream.

[michaelvoliveira]

Good point augiedoggie!

I'll take a closer look at wednesday when I'll be back from my travel

[michaelvoliveira]

merged .opd file

[michaelvoliveira]

Only builds with gcc4

[scottmc]

Please retest this one, and update as needed.

[aergus]

I have checked this port as instructed in my  Google Code-In Task. It doesn't seem to work even with gcc4.

You may check  GCC2 shell log and  GCC4 shell log on ideone.

[scottmc]

Marking this ticket as "needs work" as the currently attached files don't build successfully. @michaelvoliveira can you recheck these and make adjustments to get them working?

[michaelvoliveira]

Yes!! I'll do now

[michaelvoliveira]

A new and improved patch. Now makes reference to cstring too

[michaelvoliveira]

For GCC2, I have no idea how remove -Wfloat-equal' and -Wmissing-format-attribute' options...

[scottmc]

in the configure.ac there's no need to remove the check for socket, just add the check for network. That way you don't break it for other OSes.

[scottmc]

 http://www.google-melange.com/gci/task/view/google/gci2012/8062203