Ticket #365 (closed enhancement: moved to bitbucket haikuports site)
Opened 5 years ago
Last modified 5 months ago
SDL_Mixer - add native MIDI support
| Reported by: | michaelvoliveira | Owned by: | scottmc |
|---|---|---|---|
| Priority: | normal | Milestone: | LibPak 1.0 |
| Component: | media-libs/sdl-mixer | Version: | 1.0 |
| Severity: | normal | Keywords: | midi sdl mixer |
| Cc: |
Description
By default, sdl-mixer uses and embedded version of libtimidity to play MIDI files on Haiku, but don't work properly.
Is better create a native midi solution like macOS, Win and Linux does.
maybe doing a native_midi_haiku.c file inside native_midi folder using MIDI kit
Attachments
Change History
comment:1 Changed 5 years ago by scottmc
- Owner scottmc deleted
Changed 5 years ago by yeputons
- attachment native_midi_haiku_02.tgz added
comment:2 Changed 5 years ago by yeputons
comment:3 Changed 5 years ago by scottmc
I converted your patch so that it would patch using haikuporter but it doesn't look like it's building. Can you install haikuporter and then try using it to build sdl-mixer-1.2.11 and see if you can spot why it's not building the native_midi_haiku.cpp into it.
http://ports.haiku-files.org/browser/haikuports/trunk/media-libs/sdl-mixer/patches/sdl-mixer-1.2.11.patch?rev=1264
Also as I wrote on the task be sure to update the .cpp file with the license header info.
Changed 5 years ago by yeputons
- attachment sdl-mixer-1.2.11.patch added
comment:4 Changed 5 years ago by yeputons
Added copyright to native_midi_haiku.cpp and corrected configure.in to make it compile with haikuporter.
Also attached test apps. Please, make sure that you can play midi with MidiPlayer? before running this ones.
Changed 5 years ago by yeputons
- attachment test_apps.tgz added
comment:5 Changed 5 years ago by scottmc
- Owner set to scottmc
needs further testing prior to upstreaming. Added in r1265.
comment:6 Changed 4 years ago by scottmc
- Resolution set to fixed
- Status changed from new to closed
Patch was upstreamed back in January:
http://hg.libsdl.org/SDL_mixer/rev/4f4caf04bcd1
comment:7 Changed 4 years ago by scottmc
- Resolution fixed deleted
- Status changed from closed to reopened
it seems the end of the patch got cut off? that native_midi_stop() function isn't right and there's no terminating #endif?
yeputons do you have a complete patch still? Or know what's missing?
comment:8 Changed 4 years ago by scottmc
fixed hg patch in r1488, but it's failing to completely build from hg at this time. That could be due to recent changes in the code, not sure yet.
comment:9 Changed 4 years ago by michaelvoliveira
Are you sure that works?
I'm getting
Cannot load music: /etc/timidity.cfg: No such file or directory
from terminal...
comment:10 Changed 5 months ago by scottmc
- Resolution set to moved to bitbucket haikuports site
- Status changed from reopened to closed
I'm yeputons from GCI2010.
Here is patches for Makefile.in, configure and native_midi_haiku.cpp.
I couldn't run autoconf on my Haiku, so I've patched configure and Makefile.in (to add CXX compiler) instead of configure.in.