Ticket #402 (closed task: fixed)
Opened 5 years ago
Last modified 9 months ago
Cleanup ICU patch and upstream it.
| Reported by: | scottmc | Owned by: | pulkomandy |
|---|---|---|---|
| Priority: | normal | Milestone: | Haiku Optional Packages |
| Component: | dev-libs/icu | Version: | |
| Severity: | normal | Keywords: | |
| Cc: |
Description
The icu patch uses quite a few hacks that wouldn't be acceptable upstream. Check with upstream providers to determine which type(s) of fixes they accept and update the current haiku icu patch so that it's acceptable and can be applied upstream. It may just be adding a handful of
#ifdef __HAIKU__
cases, or something more complex. Check upstream first though, as projects can very widely on this.
Change History
comment:1 Changed 3 years ago by zooey
comment:2 Changed 9 months ago by pulkomandy
- Resolution set to fixed
- Status changed from new to closed
Tracked upstream here: http://bugs.icu-project.org/trac/ticket/8256
Note: See
TracTickets for help on using
tickets.
Just to share what I've learned:
the ICU guys usually accept our patches (although it takes them some time), except for the ones directed at getting ICU to build with gcc2. I personally find that perfectly acceptable, as those are rather circumventing bugs in gcc2.
So I guess we should keep upstreaming patches for current ICU versions once we have them (we are currently two versions behind their current release). Additionally, we need to maintain the gcc2-related part of the patch ourselves.