Haikuporter doesn't check for hg, cvs, svn, git before trying to use them

[scottmc]

Haikuporter needs to have checks added for hg, cvs, svn, git, etc before trying to make use of them and if they aren't installed prompt the use to use installoptionalpackage xxx
to install it, or prompt the user with a y/n prompt to install it.

[augiedoggie]

I think it would probably be better to put them into the dependencies of the bep file.(It would be nice if haikuporter supported the notion of "build dependencies" instead of just runtime dependencies)

Otherwise the same could be said about all the other tools needed to build software.(i.e. have checks before trying to use wget, make, gcc, autotools, patch, diff, etc...)

[scottmc]

I think we can assume autotools, patch diff, make, svn and wget, but should do runtime or buildtime checks for cmake, cvs, git, hg, bzr, and others that aren't part of the development optional packages.

Any idea on how we would go about checking the build dependencies? Perhaps make use of sqlite or test for their presence?

So maybe we have a task to update any bep files that use cmake or pull the source from a cvs/git/hg/bzr repo to have their dependencies updated.

[augiedoggie]

I had planned on adding dependency checking a long time ago but I held off because of a lack of package management. I think it would be much easier to use the future Haiku package management tools to query what is installed or not.

[jrabbit]

What we do in Fink is have a "virtual package" representing the existence of system utilities. If you don't want to add dependencies now you could just run each in a try/except...

[jrabbit]

Alright go ahead and make this a GCI task. This seems more interesting at the moment then the other haikuports issues and quicker.

[scottmc]

Haikuporter has a -y commandline option that is supposed to automatically answer yes to any questions that might be encountered during the install. So see if you can add support for this as well to the try patch. That is if say hg isn't present it will automatically try to install hg. Here's what it does with the current patch.

/boot/develop/haikuporter> haikuporter -c -d -y joe
Matching License (GNU GPL v1) found in /boot/system/data/licenses
Cleaning work directory...
No dependencies
Source checkout: hg+http://joe-editor.hg.sourceforge.net:8000/hgroot/joe-editor/joe-editor
/bin/sh: hg: command not found
Do you want to install hg? [Y/n]

[jrabbit]

Resubmitted on GCI.

[scottmc]

you're on the right track, but the -y should prevent the y/n prompt from even appearing. You are checked it too late. Try checking for it prior to displaying the message and if -y is used then skip printing the prompt and just do the install. But also make sure entering an N will stop haikuporter and exit gracefully.

[scottmc]

fixed in r1224. Thanks jrabbit.