Ticket #483 (closed defect: worksforme)
Opened 5 years ago
Last modified 4 years ago
OpenAL fails to make on gcc2
| Reported by: | jrabbit | Owned by: | scottmc |
|---|---|---|---|
| Priority: | normal | Milestone: | |
| Component: | media-libs/openal | Version: | |
| Severity: | normal | Keywords: | |
| Cc: |
Description
Attachments
Change History
Changed 5 years ago by yeputons
- attachment openal-1.12-git.patch added
comment:1 follow-up: ↓ 2 Changed 5 years ago by yeputons
comment:2 in reply to: ↑ 1 Changed 5 years ago by bonefish
comment:3 Changed 5 years ago by yeputons
That's the only reason why openal fails to compile.
So this bug should be closed as resolved.
comment:4 Changed 5 years ago by yeputons
But I think this patch is usable on release system. I have Haiku from official release ISO and cannot compile OpenAL without hack.
comment:5 Changed 5 years ago by scottmc
We should leave it unpatched, but add a MESSAGE to the bep file letting the user know they need Haiku r38236 or newer.
Changed 5 years ago by yeputons
- attachment openal.bep.patch.tgz added
comment:6 follow-up: ↓ 7 Changed 5 years ago by jrabbit
Not sure this is actually correct bonefish, I have a recent build that won't build openAL, but I can't test it atm...
comment:7 in reply to: ↑ 6 Changed 5 years ago by bonefish
Replying to jrabbit:
Not sure this is actually correct bonefish, I have a recent build that won't build openAL, but I can't test it atm...
I can't say anything about openal, but the gcc 2.95.3-haiku-100818 that's available with the current Haiku definitely supports the standard variadic macros by default. The gcc package was updated in r38376.
comment:8 Changed 4 years ago by scottmc
- Resolution set to worksforme
- Status changed from new to closed
openal builds ok with r39748 using gcc2 for me, so closing this as not needed.
We just need some hack, because GCC 2 don't understand constructions like
#define foo(...) bar(1, 2, 3, VA_ARGS)
but understand
#define foo(args...) bar(1, 2, 3, ##args)
It work perfectly.