dev-util/scons-2.0.1 - files attached

[dragon]

files attached

[dragon]

bep and patch for scons-2.0.1, extract into portage root directory

[scottmc]

Nice work so far. I've applied the first cut of the scons-2.0.1 bep and patch files in r1744, but they have a few minor issues that should be fixed.

1) We should avoid hardcoding any paths, as many of them are going to be changing soon with package management right around the corner. So the patch will need to be fixed to make use of Find_Directory(), see http://ports.haiku-files.org/wiki/FindDirectory for examples on how to use it in shell scripts and in Python.

2) Also the man files are currently just being dumped into B_COMMON_DIRECTORY/man/man1, try to patch the install script to have them put into B_COMMON_DOCUMENTATION/man/man1 in Haiku

3) For changing the "#! /usr/bin/env python" into "#! /bin/env python" try using sed in the bep file, rather than putting it in the patch. By leaving it out of the patch, that will make the patch "upstreamable", that is it won't break on other platforms and is more likely to be accepted when passed upstream, and our goal is to usually upstream patches so that they just work on the next version release.

[dragon]

1) Done. There is one particularity though and this is that the previous scons patch included the directory /boot/develop/tools/gnupro/bin. This doesn't fit into any of the constants finddir recognizes. Replaced it now with B_COMMON_DEVELOP_DIRECTORY/tools/gnupro/bin. One has to see how this is best solved later on.

2) Done

3) Done

[axeld]

Do you know for what this is actually needed? The directory should be in your path anyway, at leat -- may be one can remove that path completely.

[scottmc]

Looks good, applied in r1747, thanks.

[dragon]

Replying to axeld:

Do you know for what this is actually needed? The directory should be in your path anyway, at leat -- may be one can remove that path completely.

No idea. What goes for me it could be removed but I don't know how the others think about it.