Ticket #577 (closed task: fixed)
Opened 3 years ago
Last modified 8 months ago
Add library liblo
| Reported by: | pete | Owned by: | |
|---|---|---|---|
| Priority: | normal | Milestone: | |
| Component: | media-libs/liblo | Version: | 1.0 |
| Severity: | normal | Keywords: | |
| Cc: | pete.goodeve@… |
Description
I'm attaching the BEP and patch file for the 'liblo'(Lightweight OSC) library. (I'm assuming this should be done here. I also created a PortLog entry, where I see one can attach files, but I suspect that's not the place to do it.) It should be installed under media-libs/liblo.
Attachments
Change History
Changed 3 years ago by pete
- attachment liblo-0.26.bep added
comment:1 follow-up: ↓ 2 Changed 3 years ago by augiedoggie
comment:2 in reply to: ↑ 1 Changed 3 years ago by pete
Replying to augiedoggie:
The bep file is missing the copyright information and it would be nice if the check for libnetwork was added to the autoconf system(i.e. configure.ac).
I looked hard for a copyright -- both in the README and on the home page -- and couldn't
find anything, so I just left it out.
As for changing configure.ac, I am completely ignorant about all that, and I didn't want to mess!
The patch file contains a lot of what seems like unnecessary whitespace changes. It would also be nice to add a check for libpthread in the autoconf system and add it if needed for whatever os is being used instead of just removing it.
The whitespace changes were necessary... for me! The original is very poorly indented,
so to understand what was happening in the early stages I had to re-indent that section.
They could certainly be removed again if it seems important.
And again, I had great trouble in even figuring out where the lpthread check was being inserted, so once I made it work I left it.
I have been guilty of some of these workarounds in the past due to my hatred of autotools, so I can let them slide, but these would most likely need to be fixed in order to be accepted upstream.
I already emailed the maintainer with the (one line) fix to server.c. I mentioned that we had to re-autoconf etc, but didn't give details.
comment:3 Changed 3 years ago by pete
- Cc pete.goodeve@… added
comment:4 Changed 3 years ago by scottmc
- Resolution set to fixed
- Status changed from new to closed
applied in r1894.
comment:5 Changed 3 years ago by pete
- Resolution fixed deleted
- Status changed from closed to reopened
Apparently my original patch wasn't quite complete. One link operation failed to find libnetwork, so I've just added that. Also please fix the subdirectory name in http://ports.haiku-files.org/svn/haikuports/trunk/media-libs/liblo/: "patch" should be "patches", so haikuporter can actually find it!
comment:6 Changed 8 months ago by scottmc
- Resolution set to fixed
- Status changed from reopened to closed
In general things look ok, but not great. I haven't tested it out myself yet but from looking at the files....
The bep file is missing the copyright information and it would be nice if the check for libnetwork was added to the autoconf system(i.e. configure.ac).
The patch file contains a lot of what seems like unnecessary whitespace changes. It would also be nice to add a check for libpthread in the autoconf system and add it if needed for whatever os is being used instead of just removing it.
I have been guilty of some of these workarounds in the past due to my hatred of autotools, so I can let them slide, but these would most likely need to be fixed in order to be accepted upstream.