HaikuPorts
  • Login
  • Preferences
  • Help/Guide
  • Wiki
  • Timeline
  • Roadmap
  • View Tickets
  • Search
  • Port Log
  • Blog

Context Navigation

  • ← Previous Ticket
  • Next Ticket →

Ticket #72 (closed defect: fixed)

Opened 7 years ago

Last modified 6 years ago

Port log Edit Box seems to have one or two default space characters in by default

Reported by: scottmc Owned by: brecht
Priority: normal Milestone: HaikuPorts M1
Component: PortLogPlugin Version:
Severity: normal Keywords:
Cc:

Description

One in the upperleft on Line 1, and maybe a second one that appears at the end of the edit space, not sure on the second one. I find that I have to delete at least one space char everytime I make a new entry.

Change History

comment:1 Changed 7 years ago by brecht

  • Owner set to brecht
  • Status changed from new to assigned

The PortLogPlugin? creates 'empty' wiki pages when adding a port, version or revision entry to the database. Trac requires these new wiki pages to contain something, hence the space. I'll see whether I can create the wiki page using another method to circumvent this.

comment:2 follow-ups: ↓ 3 ↓ 4 Changed 7 years ago by scottmc

Could this be caused by line 217 in macro.py or a similar line elsewhere in the portlog code? Perhaps use instead of ' '?

comment:3 in reply to: ↑ 2 Changed 6 years ago by brecht

Replying to scottmc:

Could this be caused by line 217 in macro.py or a similar line elsewhere in the portlog code? Perhaps use '' instead of ' '?

No, this does not work. Trac complains that the page is not modified when we use ''. I have been thinking it might be better to not create a wiki page after all. This way it's immediately clear whether a port log is empty or not. The downside is that all links will have include a question mark and appear in a different color (gray). I think this might be confusion, as it appears the page does not exists, where in fact it may contain metadata.

comment:4 in reply to: ↑ 2 Changed 6 years ago by brecht

  • Resolution set to fixed
  • Status changed from assigned to closed

Replying to scottmc:

Could this be caused by line 217 in macro.py or a similar line elsewhere in the portlog code? Perhaps use '' instead of ' '?

Setting the content of the wiki page to None does seem to work however! Fixed in r306.

Note: See TracTickets for help on using tickets.

Download in other formats:

  • Comma-delimited Text
  • Tab-delimited Text
  • RSS Feed

Trac Powered

Powered by Trac 0.13dev-r10686
By Edgewall Software.

Visit the Trac open source project at
http://trac.edgewall.org/