Changes between Version 1 and Version 2 of sys-devel/m4

Timestamp:

08/14/07 07:20:20 (8 years ago)

Author:

brecht

Comment:

--

sys-devel/m4

@@ -2 +2 @@
 
 === version 1.4.10 ===
+
+||working||no||
+||maintainer||brecht||
 
 ==== revision 1 ====
@@ -7 +10 @@
 BeOS lseek() doesn't detect pipes. m4 configure only provides a replacement lseek() for MinGW:
 http://www.nabble.com/lseek-always-include-windows.h--t3867842.html
+
+A BeOS-compatible replacement for lseek() is:
+{{{
+#include <config.h>
+
+/* Specification.  */
+#include <unistd.h>
+
+#include <stdlib.h>
+#include <sys/types.h>
+#include <sys/stat.h>
+#include <errno.h>
+
+#undef lseek
+
+off_t
+rpl_lseek (int fd, off_t offset, int whence)
+{
+  int rc;
+  struct stat st;
+  if (fstat(fd, &st) < 0)
+    {
+      //fstat sets errno
+      return -1;
+    }
+  if (S_ISFIFO(st.st_mode))
+    {
+      errno = ESPIPE;
+      return -1;
+    }
+  return lseek (fd, offset, whence);;
+}
+}}}
+
+This needs to be merged with in the m4/lseek.m4 script (I think).
+
+After replacing lseek with the above code, make check still reports 3 failed tests:
+
+{{{
+ftell result is wrong after fseeko: 17.
+FAIL: test-fflush
+}}}
+  I'm not sure whether the problem is with fseeko or ftell.
+
+{{{
+FAIL: test-ftello.sh
+}}}
+  ftell and ftello should return -1 for pipes. On BeOS, they don't.
+
+{{{
+test-lseek.c:52: assertion failed
+Abort
+FAIL: test-lseek.sh
+}}}
+  Haven't investigated this yet.